Skip to content

Commit

Permalink
Fix Rubocop violations
Browse files Browse the repository at this point in the history
  • Loading branch information
lbeder committed Nov 15, 2020
1 parent f62f420 commit 531fe36
Show file tree
Hide file tree
Showing 3 changed files with 57 additions and 9 deletions.
60 changes: 55 additions & 5 deletions .rubocop.yml
Expand Up @@ -2,11 +2,6 @@
AllCops:
TargetRubyVersion: 2.5

Metrics/LineLength:
Max: 120
Exclude:
- 'spec/**/*'

Metrics/MethodLength:
Max: 20
Exclude:
Expand All @@ -32,6 +27,7 @@ Style/Documentation:
Enabled: false

Style/BlockDelimiters:
Enabled: true
Exclude:
- 'spec/**/*'

Expand Down Expand Up @@ -101,6 +97,29 @@ Style/SlicingWithRange:
Style/StringConcatenation:
Enabled: true

Style/ArgumentsForwarding:
Enabled: true

Style/CollectionCompact:
Enabled: true

Style/DocumentDynamicEvalDefinition:
Enabled: true

Style/NegatedIfElseCondition:
Enabled: true

Style/NilLambda:
Enabled: true

Style/SwapValues:
Enabled: true

Layout/LineLength:
Max: 120
Exclude:
- 'spec/**/*'

Layout/ParameterAlignment:
EnforcedStyle: with_fixed_indentation

Expand All @@ -123,6 +142,7 @@ Layout/EmptyLinesAroundAttributeAccessor:
Enabled: true

Lint/RescueException:
Enabled: true
Exclude:
- 'lib/health_monitor/providers/**/*'

Expand Down Expand Up @@ -167,3 +187,33 @@ Lint/TopLevelReturnWithArgument:

Lint/UnreachableLoop:
Enabled: true

Lint/ConstantDefinitionInBlock:
Enabled: true
Exclude:
- 'spec/**/*'

Lint/DuplicateBranch:
Enabled: true

Lint/DuplicateRegexpCharacterClassElement:
Enabled: true

Lint/EmptyBlock:
Enabled: true
Exclude:
- 'spec/**/*'

Lint/EmptyClass:
Enabled: true
Exclude:
- 'spec/**/*'

Lint/NoReturnInBeginEndBlocks:
Enabled: true

Lint/ToEnumArguments:
Enabled: true

Lint/UnmodifiedReduceAccumulator:
Enabled: true
3 changes: 1 addition & 2 deletions spec/dummy/db/schema.rb
Expand Up @@ -12,5 +12,4 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 0) do
end
ActiveRecord::Schema.define(version: 0)
3 changes: 1 addition & 2 deletions spec/lib/health_monitor/monitor_spec.rb
Expand Up @@ -69,8 +69,7 @@

describe 'error_callback' do
it 'configures' do
error_callback = proc do
end
error_callback = proc {}

expect {
subject.configure do |config|
Expand Down

0 comments on commit 531fe36

Please sign in to comment.