Skip to content

Commit

Permalink
Merge pull request #77 from lbeder/updates
Browse files Browse the repository at this point in the history
Updates project and tests
  • Loading branch information
lbeder committed Dec 24, 2021
2 parents d0d29af + 9ce9771 commit 717f222
Show file tree
Hide file tree
Showing 6 changed files with 129 additions and 10 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ tmp
coverage
spec/dummy/log
gemfiles/*gemfile.lock
vendor/bundle
.bundle
115 changes: 115 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Metrics/BlockLength:
Exclude:
- 'spec/**/*'

Security/IoMethods:
Enabled: true

Style/SignalException:
EnforcedStyle: only_raise

Expand Down Expand Up @@ -115,6 +118,58 @@ Style/NilLambda:
Style/SwapValues:
Enabled: true

Style/EndlessMethod:
Enabled: true

Style/FileRead:
Enabled: true

Style/FileWrite:
Enabled: true

Style/HashConversion:
Enabled: true

Style/HashExcept:
Enabled: true

Style/IfWithBooleanLiteralBranches:
Enabled: true

Style/InPatternThen:
Enabled: true

Style/MapToHash:
Enabled: true

Style/MultilineInPatternThen:
Enabled: true

Style/NumberedParameters:
Enabled: true

Style/NumberedParametersLimit:
Enabled: true

Style/OpenStructUse:
Enabled: true

Style/QuotedSymbols:
Enabled: true

Style/RedundantArgument:
Enabled: true

Style/RedundantSelfAssignmentBranch:
Enabled: true

Style/SelectByRegexp:
Enabled: true

Style/StringChars:
Enabled: true


Layout/LineLength:
Max: 120
Exclude:
Expand All @@ -141,6 +196,12 @@ Layout/SpaceAroundMethodCallOperator:
Layout/EmptyLinesAroundAttributeAccessor:
Enabled: true

Layout/LineEndStringConcatenationIndentation:
Enabled: true

Layout/SpaceBeforeBrackets:
Enabled: true

Lint/RescueException:
Enabled: true
Exclude:
Expand Down Expand Up @@ -217,3 +278,57 @@ Lint/ToEnumArguments:

Lint/UnmodifiedReduceAccumulator:
Enabled: true

Lint/AmbiguousAssignment:
Enabled: true

Lint/AmbiguousOperatorPrecedence:
Enabled: true

Lint/AmbiguousRange:
Enabled: true

Lint/DeprecatedConstants:
Enabled: true

Lint/EmptyInPattern:
Enabled: true

Lint/IncompatibleIoSelectWithFiberScheduler:
Enabled: true

Lint/LambdaWithoutLiteralBlock:
Enabled: true

Lint/NumberedParameterAssignment:
Enabled: true

Lint/OrAssignmentToConstant:
Enabled: true

Lint/RedundantDirGlobSort:
Enabled: true

Lint/RequireRelativeSelfPath:
Enabled: true

Lint/SymbolConversion:
Enabled: true

Lint/TripleQuotes:
Enabled: true

Lint/UnexpectedBlockArity:
Enabled: true

Lint/UselessRuby2Keywords:
Enabled: true

Naming/BlockForwarding:
Enabled: true

Gemspec/DateAssignment:
Enabled: true

Gemspec/RequireMFA:
Enabled: true
11 changes: 6 additions & 5 deletions health-monitor-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ Gem::Specification.new do |s|
s.email = ['leonid.beder@gmail.com']
s.license = 'MIT'
s.homepage = 'https://github.com/lbeder/health-monitor-rails'
s.summary = 'Health monitoring Rails plug-in, which checks various services (db, cache, '\
'sidekiq, redis, etc.)'
s.description = 'Health monitoring Rails plug-in, which checks various services (db, cache, '\
'sidekiq, redis, etc.).'
s.summary = 'Health monitoring Rails plug-in, which checks various services (db, cache, sidekiq, redis, etc.)'
s.description = 'Health monitoring Rails plug-in, which checks various services (db, cache, sidekiq, redis, etc.).'

s.files = Dir['{app,config,db,lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.md']
s.test_files = Dir['test/**/*']
Expand All @@ -31,13 +29,16 @@ Gem::Specification.new do |s|
s.add_development_dependency 'delayed_job_active_record', '>= 4.1'
s.add_development_dependency 'pry'
s.add_development_dependency 'rake'
s.add_development_dependency 'rediska', '>= 1.0'
s.add_development_dependency 'rediska', '>= 1.1.0'
s.add_development_dependency 'resque'
s.add_development_dependency 'rspec-rails'
s.add_development_dependency 'rubocop', '>= 0.5'
s.add_development_dependency 'sidekiq', '>= 3.0'
s.add_development_dependency 'spork'
s.add_development_dependency 'sqlite3', '>= 1.3'
s.add_development_dependency 'timecop'
s.metadata = {
'rubygems_mfa_required' => 'true'
}
end
# rubocop:enable Metrics/BlockLength
3 changes: 1 addition & 2 deletions lib/health_monitor/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ def no_database

def add_custom_provider(custom_provider_class)
unless custom_provider_class < HealthMonitor::Providers::Base
raise ArgumentError.new 'custom provider class must implement '\
'HealthMonitor::Providers::Base'
raise ArgumentError.new 'custom provider class must implement HealthMonitor::Providers::Base'
end

add_provider(custom_provider_class)
Expand Down
2 changes: 1 addition & 1 deletion lib/health_monitor/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module HealthMonitor
VERSION = '9.0.0'
VERSION = '9.1.0'
end
6 changes: 4 additions & 2 deletions spec/lib/health_monitor/providers/sidekiq_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@
it { expect(described_class.new.latency).to eq(default_latency) }
it { expect(described_class.new.queue_size).to eq(default_queue_size) }
it do
expect(described_class.new.queues[default_queue_name]).to eq(latency: default_latency,
queue_size: default_queue_size)
expect(described_class.new.queues[default_queue_name]).to eq(
latency: default_latency,
queue_size: default_queue_size
)
end
end
end
Expand Down

0 comments on commit 717f222

Please sign in to comment.