Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis.configuration.connection & Sidekiq.configuration.queues_size #29

Merged
merged 5 commits into from
Dec 27, 2017
Merged

Redis.configuration.connection & Sidekiq.configuration.queues_size #29

merged 5 commits into from
Dec 27, 2017

Conversation

sveredyuk
Copy link

@sveredyuk sveredyuk commented Dec 22, 2017 •
edited

Closed #28

@coveralls
Copy link

coveralls commented Dec 22, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.136% when pulling 81d37ba on sveredyuk:master into ef63747 on lbeder:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.136% when pulling 81d37ba on sveredyuk:master into ef63747 on lbeder:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.136% when pulling 81d37ba on sveredyuk:master into ef63747 on lbeder:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.136% when pulling 81d37ba on sveredyuk:master into ef63747 on lbeder:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 99.136% when pulling 81d37ba on sveredyuk:master into ef63747 on lbeder:master.

@coveralls
Copy link

coveralls commented Dec 26, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.138% when pulling 68e8eb5 on sveredyuk:master into ef63747 on lbeder:master.

@sveredyuk sveredyuk changed the title Redis.configuration.connection Redis.configuration.connection & Redis.configuration.queues_size Dec 26, 2017
@sveredyuk sveredyuk changed the title Redis.configuration.connection & Redis.configuration.queues_size Redis.configuration.connection & Sidekiq.configuration.queues_size Dec 26, 2017
lbeder
lbeder reviewed Dec 26, 2017
View reviewed changes
README.md Outdated
@@ -151,7 +151,8 @@ Some of the providers can also accept additional configuration:
# Sidekiq
HealthMonitor.configure do |config|
config.sidekiq.configure do |sidekiq_config|
sidekiq_config.latency = 3.hours
sidekiq_config.latency = 3.hours
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you align the =?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

lbeder
lbeder reviewed Dec 26, 2017
View reviewed changes
README.md Outdated
@@ -171,6 +172,7 @@ The currently supported settings are:
#### Sidekiq

* `latency`: the latency (in seconds) of a queue (now - when the oldest job was enqueued) which is considered unhealthy (the default is 30 seconds, but larger processing queue should have a larger latency value).
* `queue_size`: the size (maximim) of a queue which is considered unhealthy (the default is 100.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the missing )?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofc.

@coveralls
Copy link

coveralls commented Dec 26, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.162% when pulling fb21702 on sveredyuk:master into ef63747 on lbeder:master.

@coveralls
Copy link

coveralls commented Dec 26, 2017 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.162% when pulling 8d2ee38 on sveredyuk:master into ef63747 on lbeder:master.

@lbeder lbeder merged commit b6eac96 into lbeder:master Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbeder lbeder lbeder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sveredyuk @coveralls @lbeder