Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W.diag plots messes up with user settings. #10

Closed
lbelzile opened this issue Nov 21, 2020 · 2 comments
Closed

W.diag plots messes up with user settings. #10

lbelzile opened this issue Nov 21, 2020 · 2 comments
Assignees
@lbelzile
Labels
bug enhancement

Comments

@lbelzile
Copy link
Owner

The current code resets the parameters of the graphics console, which prevents people from adding graphs to existing plots. It also is particularly unwanted if the code returns no plot (plots=NA).
@lbelzile lbelzile self-assigned this Nov 21, 2020
lbelzile pushed a commit that referenced this issue Mar 11, 2022
Breaking change: do not reset par() in W.diag (#10)
ce255f5
@lbelzile
Copy link
Owner Author

Current solution (a breaking change) is to let users fix graphical parameters themselves.

@lbelzile
Copy link
Owner Author

Changed my mind: added an additional argument (logical) changepar. If FALSE, the graphical parameters are left unchanged, so this should give the desired effect. Unfortunately, the behaviour is inconsistent from one graphical threshold diagnostic to the next...

lbelzile pushed a commit that referenced this issue Mar 11, 2022
Revert changes and add additional argument (#10)
dd722ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbelzile lbelzile

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lbelzile