Remove verbose mode from service, add parameters for additional service options #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why you need verbose? |
|
Verbose was the default in the module. To keep the behaviour consistent with the previous version, I set the thefault to this. I actually need to specify -N , as csync2 seems to use the short hostname by default instead of the fqdn (as stated in the docs). Our certificates use fqdns by default and if we replicate across datacenters or firecells, short hostnames may be identical but the fqdns are not. |
lbetz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to pass additional parameters to the systemd service apart from -v. This PR allows changing the options passed to the .service file