Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github action for coveralls, readme badges, metadata refactor #246

Merged
merged 24 commits into from Apr 28, 2021
Merged

Github action for coveralls, readme badges, metadata refactor #246

merged 24 commits into from Apr 28, 2021

Conversation

jccurtis
Copy link
Collaborator

@jccurtis jccurtis commented Mar 11, 2021 •
edited

Following this action. Live on coveralls

Closes #40
Closes #228

@jccurtis jccurtis self-assigned this Mar 11, 2021
@jccurtis
Copy link
Collaborator Author

Note to self: I think this test failure is caused by the relative file configuration but I'm not sure why that is important for pytest when the configuration is for coverage:

https://github.com/lbl-anp/becquerel/pull/246/checks?check_run_id=2090447134#step:7:18

@jccurtis
Copy link
Collaborator Author

@cosama any thoughts why this __metadata__ error is occurring now? https://github.com/lbl-anp/becquerel/pull/246/checks?check_run_id=2090447250#step:6:14

@jccurtis jccurtis changed the title WIP: Github action for coveralls WIP: Github action for coveralls, readme badges, metadata refactor Mar 18, 2021
@jccurtis
Copy link
Collaborator Author

@markbandstra after several (unrelated) fixes this is working nicely. Can you check it out?

@jccurtis jccurtis changed the title WIP: Github action for coveralls, readme badges, metadata refactor Github action for coveralls, readme badges, metadata refactor Mar 18, 2021
markbandstra
markbandstra reviewed Mar 24, 2021
View reviewed changes
setup.py Show resolved Hide resolved
@markbandstra
Copy link
Member

We should probably update RELEASING.txt since it contains these steps:

  • Update version number within the repository
    • in setup.py
    • in Copyright Notice in README
    • in the LICENSE

Like my other comment about the Copyright text, could we have the version number be set in __metadata__.py and populated across these other locations? Then this step could be reduced to "Update version number in __metadata__.py", for example.

@jccurtis
Copy link
Collaborator Author

@markbandstra another good point. I might add bump2version to just centralize the version number localization and simplify bumping

@jccurtis
Copy link
Collaborator Author

@markbandstra I added tests to assure the copyright is the same in 4 places: ca037fd

@jccurtis jccurtis mentioned this pull request Apr 28, 2021
Merged
markbandstra
markbandstra approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@markbandstra markbandstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this is really helpful for maintaining our metadata.

@jccurtis jccurtis merged commit 54d5fc9 into main Apr 28, 2021
@jccurtis jccurtis deleted the gh-actions-coveralls branch April 28, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbandstra markbandstra markbandstra approved these changes

Assignees

@jccurtis jccurtis

Labels
new feature testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconfigure how __metadata__ is handled Use Coveralls for integrated code coverage reporting
2 participants
@jccurtis @markbandstra