Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration fit statistics #265

Merged
merged 9 commits into from Apr 20, 2021
Merged

Calibration fit statistics #265

merged 9 commits into from Apr 20, 2021

Conversation

jvavrek
Copy link
Contributor

@jvavrek jvavrek commented Apr 20, 2021 •
edited

Fit stats for calibrations:

  • R^2
  • chi^2
  • dof
  • reduced chi^2

@jvavrek
Copy link
Contributor Author

jvavrek commented Apr 20, 2021 •
edited

@markbandstra any thoughts on this merging this into new-calibration? In addition to fit statistics, I also added a plot() method similar to what I added to energycal.py earlier. There are also some basic tests that we can expand upon if we add more tests of correctness before merging the combined branch into main.

markbandstra
markbandstra approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@markbandstra markbandstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks for adding these features!

@jvavrek jvavrek merged commit a9f4502 into new-calibration Apr 20, 2021
@jvavrek jvavrek deleted the cal-fit-stats branch April 20, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbandstra markbandstra markbandstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvavrek @markbandstra