Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update peakfinder to suppress double peaks and update plots #266

Merged
merged 8 commits into from May 6, 2021
Merged

update peakfinder to suppress double peaks and update plots #266

merged 8 commits into from May 6, 2021

Conversation

jvavrek
Copy link
Contributor

@jvavrek jvavrek commented Apr 23, 2021 •
edited

TODO:

  • add a regression test: test that old peakfinder logic produces double peaks and new logic does not

@jvavrek jvavrek mentioned this pull request Apr 23, 2021
Closed
@jvavrek jvavrek changed the title Draft: update peakfinder to suppress double peaks and update plots update peakfinder to suppress double peaks and update plots May 6, 2021
@jvavrek jvavrek requested a review from markbandstra May 6, 2021 20:06
markbandstra
markbandstra approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@markbandstra markbandstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@jvavrek jvavrek merged commit e78968d into main May 6, 2021
@jvavrek jvavrek deleted the edit-peakfinder branch May 6, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbandstra markbandstra markbandstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvavrek @markbandstra