Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a square root binning function #280

Merged
merged 4 commits into from Aug 4, 2021
Merged

Implement a square root binning function #280

merged 4 commits into from Aug 4, 2021

Conversation

dhellfeld
Copy link
Collaborator

Simple util to generate square root bins.

@dhellfeld dhellfeld requested a review from jccurtis July 21, 2021 22:14
@dhellfeld dhellfeld self-assigned this Jul 21, 2021
jvavrek
jvavrek reviewed Jul 21, 2021
View reviewed changes
becquerel/core/utils.py Outdated Show resolved Hide resolved
@dhellfeld
Copy link
Collaborator Author

dhellfeld commented Jul 22, 2021 •
edited

@jccurtis Thoughts?

jccurtis
jccurtis approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@jccurtis jccurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test

@dhellfeld dhellfeld merged commit 0c79588 into main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvavrek jvavrek jvavrek left review comments

@jccurtis jccurtis jccurtis approved these changes

Assignees

@dhellfeld dhellfeld

Labels
effort-low new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhellfeld @jccurtis @jvavrek