Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For regression tests, a different end time should give an error rather than a warning #404

Closed
mwetter opened this issue Mar 16, 2021 · 0 comments
Closed

For regression tests, a different end time should give an error rather than a warning #404

mwetter opened this issue Mar 16, 2021 · 0 comments
Assignees
@mwetter

Comments

@mwetter
Copy link
Member

mwetter commented Mar 16, 2021

When running regression tests and the simulation terminates, and hence the end time is different from the reference results, the tests should write an error. Currently, it writes a warning.
@mwetter mwetter self-assigned this Mar 16, 2021
mwetter added a commit that referenced this issue Mar 16, 2021
@mwetter
Changed warning to an error
5c1c01d 
For #404
@mwetter mwetter mentioned this issue Mar 16, 2021
Closed
mwetter added a commit that referenced this issue Mar 23, 2021
@mwetter @dependabot
Bump jinja2 from 2.11.1 to 2.11.3 (#409)
5cf473f 
* Changed warning to an error

For #404

* Removed 0 in statistics comparison

For #406

* Updated change log

* Corrected key name

* Bump jinja2 from 2.11.1 to 2.11.3

Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.1 to 2.11.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/master/CHANGES.rst)
- [Commits](pallets/jinja@2.11.1...2.11.3)

Signed-off-by: dependabot[bot] <support@github.com>

* Added test and changed expected results as 0 is now ignored

* Corrected link and formatted code

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mwetter mwetter closed this as completed Mar 23, 2021
mwetter added a commit that referenced this issue Mar 23, 2021
@mwetter
Issue406 statistics zeros (#407)
f1ddb12 
* Changed warning to an error

For #404

* Removed 0 in statistics comparison

For #406

* Updated change log

* Corrected key name

* Added test and changed expected results as 0 is now ignored

* Corrected link and formatted code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed warning to an error if results start and end time differ lbl-srg/BuildingsPy
1 participant
@mwetter