Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with MBL master #365

Closed
AntoineGautier opened this issue Oct 13, 2023 · 2 comments
Closed

Incompatibility with MBL master #365

AntoineGautier opened this issue Oct 13, 2023 · 2 comments
Assignees

Comments

@AntoineGautier
Copy link
Collaborator

AntoineGautier commented Oct 13, 2023

Through #358 it was detected that the current version of the app is not compatible with MBL master, at least from commit https://github.com/lbl-srg/modelica-buildings/tree/3185e8f328 where the first version of the Templates package was merged.

Some class names in Guideline 36-2021 (mappings).csv are obsolete. All component interface classes must be modified from Buildings.Templates.(AirHandlersFans|ZoneEquipment).Components.*.Interfaces to Buildings.Templates.(AirHandlersFans|ZoneEquipment).Components.Interfaces.*.

✅ Tests show that fixing class names within the mapping file solves the issue. The exported SOO document then contains the appropriate sections related to OA & RA dampers.

Capture d’écran 2023-10-18 à 14 13 07
@AntoineGautier AntoineGautier self-assigned this Oct 13, 2023
AntoineGautier added a commit that referenced this issue Oct 18, 2023
@AntoineGautier
Copy link
Collaborator Author

Through lbl-srg/modelica-buildings#3531, some class names used in Guideline 36-2021 (mappings).csv have been modified:

  • Buildings.Controls.OBC.ASHRAE.G36.Types.BuildingPressureControlTypes has been renamed into Buildings.Controls.OBC.ASHRAE.G36.Types.PressureControl.

@AntoineGautier
Copy link
Collaborator Author

Addressed with #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant