Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong UA value in SolarCollectors.BaseClasses.ASHRAEHeatLoss #1073

Closed
DPatteeuw opened this issue Nov 21, 2017 · 2 comments · Fixed by #1076
Closed

Wrong UA value in SolarCollectors.BaseClasses.ASHRAEHeatLoss #1073

DPatteeuw opened this issue Nov 21, 2017 · 2 comments · Fixed by #1076
Labels

Comments

@DPatteeuw
Copy link

There is a mistake in the model Buildings.Fluid.SolarCollectors.BaseClasses.ASHRAEHeatLoss
The UA value is calculated in a wrong way. You can solve this problem by changing:
-QLosInt[i] * nSeg = UA * (TFlu[i] - TEnv);
to
-QLosInt[i] * nSeg = -slope*A_c * (TFlu[i] - TEnv);

It is hard to tell the difference in the standard validation file: Buildings.Fluid.SolarCollectors.Validation.FlatPlate
I guess that is why the error was not noticed.

You can clearly see the mistake by following these steps:

  • Simulate Buildings.Fluid.SolarCollectors.Validation.FlatPlate

  • Plot the heat gain and heat losses of the panel: plot({"solCol.heaGai[1].Q_flow","solCol.rho","solCol.QLos[1].Q_flow"});

  • Now in 'SolCol' of this model, change "npanels" to 100

  • Plot again the heat gain and heat losses of the panel: plot({"solCol.heaGai[1].Q_flow","solCol.rho","solCol.QLos[1].Q_flow"});

As you can see, the heat gain scales with the number of panels. The heat losses do not.

@mwetter
Copy link
Member

mwetter commented Nov 21, 2017

@DPatteeuw : Thanks for reporting. I am working on a bug fix and a validation case so that this problem will be fixed.

@mwetter
Copy link
Member

mwetter commented Nov 21, 2017

@DPatteeuw I corrected the bug and added validation tests in Buildings.Fluid.SolarCollectors.Validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants