Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify mass and species balance. #165

Closed
mwetter opened this issue Jul 30, 2013 · 2 comments
Closed

Verify mass and species balance. #165

mwetter opened this issue Jul 30, 2013 · 2 comments
Assignees
@mwetter
Labels
Fluid
Milestone
Release 1.5

Comments

@mwetter
Copy link
Member

mwetter commented Jul 30, 2013

In ConservationEquation.mo and in StaticTwoPortConservationEquation.mo, verify mass and species balance.
@ghost ghost assigned mwetter Jul 30, 2013
mwetter added a commit that referenced this issue Jul 30, 2013
@mwetter
Changed connectors for ticket #165.
4b1cece
@mwetter
Copy link
Member Author

mwetter commented Jul 30, 2013

0 = mb_flow + sum(mXi_flow);
is correct because sum(mXi_flow) is the mass added through the input connector.
The input connector mXi_flow will be renamed to mWat_flow.

@mwetter
Copy link
Member Author

mwetter commented Aug 1, 2013

This issue is addressed by renaming the connectors to avoid an ambiguity in the model equation. The equations were correct.

mwetter added a commit that referenced this issue Aug 1, 2013
@mwetter
Changed connector for issue #165.
419bb80
mwetter added a commit that referenced this issue Aug 1, 2013
@mwetter
Updated reference results for issue #165.
0251f55 
Minor differences due to change in numerics.
mwetter added a commit that referenced this issue Aug 1, 2013
@mwetter
Removed sum where it is not needed. (Issue #165)
fc9a056
mwetter added a commit that referenced this issue Aug 1, 2013
@mwetter
Updated documentation for issue #165.
682c759
@mwetter mwetter mentioned this issue Aug 1, 2013
Merged
@mwetter mwetter closed this as completed Sep 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
Fluid
Projects
None yet
Milestone
Release 1.5
Development

No branches or pull requests
1 participant
@mwetter