Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Buildings.Controls.OBC.CDL.Psychrometrics #2139

Closed
mwetter opened this issue Sep 17, 2020 · 0 comments · Fixed by #2155
Closed

Refactor Buildings.Controls.OBC.CDL.Psychrometrics #2139

mwetter opened this issue Sep 17, 2020 · 0 comments · Fixed by #2155
Assignees
@mwetter
Labels
OpenBuildingControl
Milestone
Release 8.0

Comments

@mwetter
Copy link
Member

mwetter commented Sep 17, 2020

The blocks
Buildings.Controls.OBC.CDL.Psychrometrics.TDewPoi_TDryBulPhi
Buildings.Controls.OBC.CDL.Psychrometrics.TWetBul_TDryBulPhi
take as an input p, which is not used. This can be removed.

The block
Buildings.Controls.OBC.CDL.Psychrometrics.h_TDryBulPhi
takes as an input p, this should be removed and instead an parameter pAtm = 101325 should be used, with annotation tab=Advanced.

To distinguish them from the blocks with the same name in Buildings.Utilities, we may want to move them to Obsolete and rename them to DewPoint_TDryBulPhi, WetBulb_TDryBulPhi and SpecificEnthalpy_TDryBulPhi.
@mwetter mwetter added this to the Release 8.0 milestone Sep 29, 2020
@mwetter mwetter self-assigned this Sep 29, 2020
mwetter added a commit that referenced this issue Sep 29, 2020
@mwetter
Renamed existing blocks
bd9d0b9 
For #2139
@mwetter mwetter mentioned this issue Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
OpenBuildingControl
Projects
None yet
Milestone
Release 8.0
Development

Successfully merging a pull request may close this issue.

Update CDL.Psychrometrics package lbl-srg/modelica-buildings
1 participant
@mwetter