Single Zone VAV Conventional Controller Not Cooling in Setup

[dhblum]

I believe there is a bug in Buildings.Air.Systems.SingleZone.VAV.ChillerDXHeatingEconomizerController where the controller does not turn on the fan if cooling is needed in setup (that is, during unoccupied hours but the room temperature still goes above the higher zone air temperature cooling setpoint).

In addition, I believe:

• the controller component model should be located in Buildings.Air.Systems.SingleZone.VAV.BaseClasses with the other controllers
• it's name changed to ControllerChillerDXHeatingEconomizer to be more consistent with the other controllers
• validation example added to Buildings.Air.Systems.SingleZone.VAV.BaseClasses.Validation to check for the above condition and make sure it is fixed

A validation model has been made to reproduce the bug. It can be seen in the screenshot below at the time indicated. Here, the fan should turn on to cool the space, but does not (as seen in the second plot).

The proposed fix is to add a connection between orFan and chOnTRoo as shown in the figure below. Note that the existing description of orFan is "Switch fan on if heating, cooling, or occupied" so I believe this issue address the already intended operation.

Then, the validation model shows the desired behavior in the Figure below.

[dhblum]

My above comments are addressed in #2266.

[mwetter]

Merged on the master.