Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn does Updating Shadowing Calculations starting in January even if simulation starts in summer #2453

Closed
mwetter opened this issue Apr 16, 2021 · 5 comments
Assignees
Labels
enhancement spawn Development for Spawn of EnergyPlus
Projects
Milestone

Comments

@mwetter
Copy link
Member

mwetter commented Apr 16, 2021

On branch scale_eplus_floor, commit cf98372
the command:

OutputCPUtime = true;
Advanced.ParallelizeCode = false;
Advanced.SparseActivate = true;
modelInstance="Buildings.Examples.ScalableBenchmarks.ZoneScaling.EnergyPlus.Large4Floors()";
simulateModel(modelInstance, startTime=16848000, stopTime=17280000, method="CVode", tolerance=1e-05, resultFile="Large4Floors", numberOfIntervals=500);

Takes about 60 seconds to initialize the model. Running dymosim from the bash console shows that EnergyPlus updates the shading calculations from the start of the year to the actually requested simulation period first:

Updating Shadowing Calculations, Start Date=01/08/2017
Continuing Simulation at 01/08/2017 for SPAWN-RUNPERIOD
Updating Shadowing Calculations, Start Date=01/15/2017
Continuing Simulation at 01/15/2017 for SPAWN-RUNPERIOD
Updating Shadowing Calculations, Start Date=01/22/2017
...
Updating Shadowing Calculations, Start Date=06/25/2017
Continuing Simulation at 06/25/2017 for SPAWN-RUNPERIOD
Updating Shadowing Calculations, Start Date=07/02/2017
Continuing Simulation at 07/02/2017 for SPAWN-RUNPERIOD
Updating Shadowing Calculations, Start Date=07/09/2017
Continuing Simulation at 07/09/2017 for SPAWN-RUNPERIOD

This takes considerable time (about a minute). This issue is to see if EnergyPlus can be changed so it only computes the shading calculations that are needed for the simulation.

@mwetter mwetter added enhancement spawn Development for Spawn of EnergyPlus labels Apr 16, 2021
@kbenne
Copy link
Contributor

kbenne commented Apr 16, 2021

This has been at the top of @nllong 's list for a while. Happy to get this in the queue. The solution is to look at the given fmu start time and then modify the idf file run period appropriately.

@kbenne
Copy link
Contributor

kbenne commented May 12, 2022

@mwetter correct me if I'm wrong, but I think we are going to table this for 9.0 release.

@mwetter mwetter modified the milestones: Release 9.0, Release 9.1 May 12, 2022
@mwetter
Copy link
Member Author

mwetter commented May 12, 2022

@kbenne : Correct, that's for past 9.0.

@mwetter mwetter modified the milestones: Release 9.1, Release 10.0 Nov 30, 2022
@mwetter mwetter modified the milestones: Release 10.0, Release 11.0 Sep 5, 2023
@mwetter
Copy link
Member Author

mwetter commented Aug 21, 2024

This should be fixed on the master. LBL to check.

@mwetter
Copy link
Member Author

mwetter commented Aug 21, 2024

This is now corrected on the master branch (as tested by running the above model on the console with OpenModelica with start time of 300 days.

@mwetter mwetter closed this as completed Aug 21, 2024
@mwetter mwetter moved this from To do to Done in Spawn Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement spawn Development for Spawn of EnergyPlus
Projects
Spawn
Done
Development

No branches or pull requests

2 participants