Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct error in documentation of PID and PIDWithReset in OBC.CDL #2994

Closed
mwetter opened this issue May 6, 2022 · 1 comment
Closed

Correct error in documentation of PID and PIDWithReset in OBC.CDL #2994

mwetter opened this issue May 6, 2022 · 1 comment

Comments

@mwetter
Copy link
Member

mwetter commented May 6, 2022

In the documentation of Buildings.Controls.OBC.CDL.Continuous.PIDWithReset, it mentions that

The derivative of the control error d ⁄ dt e(t) is approximated using

d⁄dt x(t) = (e(t)-x(t)) Td ⁄ Nd,

This should be

d⁄dt x(t) = (e(t)-x(t)) Nd ⁄ Td

Originally posted by @SenHuang19 in #2993 (comment)
@mwetter mwetter mentioned this issue May 6, 2022
Closed
@mwetter
Copy link
Member Author

mwetter commented May 13, 2022

This has been corrected on the master and in the 8.1.1 release.

@mwetter mwetter closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwetter