-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The wet coil generates an unrealistic sensible heat exchange rate #3027
Comments
@mwetter |
@SenHuang19 I plan to look at it this week but have a few other items to finish before I can devote time on analyzing this. Do you have a small unit test that reproduces the issue? This always helps in debugging and making sure the issue does not occur again when models are being revised. |
@mwetter |
Easiest would be to make a PR to |
Thanks, I will make a PR then. Can you please point me to an example of the unit test? Just want to make sure I follow the convention. |
Simply adding a small unit test that reproduces the problem would suffice, e.g., a test as we have for any other model, but with parameters configured so that it reproduces the problem you observe. This way we can analyze it, fix it, and it becomes part of the CI tests. |
Sure, please take a look at #3043. |
Thanks. I processed your PR and the model |
Thanks. Please let me know if I can help on it. We have some measurement data, which may be useful for the validation. |
@SenHuang19 : In the plot you uploaded at #3049 (comment), what is the expected result? The plot shows |
Yes, I was expecting that By the way, can you please elaborate on how the dynamics of the heat exchanger affect the heat balance of the air? |
@SenHuang19 : Please check the temperatures of |
* Updated release notes and date * Added bug fix for #3027, updated releases notes and date
@mwetter Thanks a lot for your explanation. |
@SenHuang19 : Period 1 can be ignored as the mass flow rate is 0, and hence For Period 2, the energy seems to be stored in For Period 3, mass flow rates are 0, and also |
@mwetter I created a simple example to reproduce the issues for Period 2 and 3. |
Merged to branch What exactly do you want me to look at? The model seems fine: |
@SenHuang19 : The outlet air temperature increases because the water This dynamic is configured via the parameters |
@mwetter Thank you so much for your detailed explanation. |
@SenHuang19 : The variable |
@mwetter : |
This has been corrected on the |
In
Buildings.Fluid.HeatExchangers.WetCoilCounterFlow
, the sensible heat exchange rate is calculated by:If
Q2_flow
is lower thanQLat2_flow
, thenQSen2_flow
is positive evenQ2_flow
andQLat2_flow
are negative.In this case, the coil is heating the air.
This error can be triggered when the water flow rate is lower while the air flow rate is still high (e.g., the air-side economizer is on). In this case, the
Q2_flow
is lower butQLat2_flow
may be higher since it is not directly related to the water side condition, as shown below:The text was updated successfully, but these errors were encountered: