Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SmallOffice.Guideline36Spring stalls when fan switches on #3106

Closed
mwetter opened this issue Sep 9, 2022 · 0 comments · Fixed by #3107
Closed

SmallOffice.Guideline36Spring stalls when fan switches on #3106

mwetter opened this issue Sep 9, 2022 · 0 comments · Fixed by #3107
Assignees
@mwetter
Milestone
Release 9.1

Comments

@mwetter
Copy link
Member

mwetter commented Sep 9, 2022 •
edited

The command

simulateModel("Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.Guideline36Spring", startTime=7344000, stopTime=7365605.35683428, method="Cvode", tolerance=1e-08, resultFile="Guideline36Spring");

stalls with Dymola 2023 and Optimica on branch issue2668_fanEfficiencyEuler, commit df2e615.

The problem is the hysteresis in
Buildings/Controls/OBC/ASHRAE/G36_PR1/AHUs/MultiZone/VAV/SetPoints/OutdoorAirFlow/AHU.mo
which is configured with 1E-4 and 1E-5, respectively and chatters when the fan switches on the first time.

The hysteresis is used to implement a guard against division by zero.
This can be refactored using a max function which does not trigger events.

The development branch is issue3106_G36_ventilationEffectiveness
@mwetter mwetter added this to the Release 9.1 milestone Sep 9, 2022
@mwetter mwetter self-assigned this Sep 9, 2022
mwetter added a commit that referenced this issue Sep 9, 2022
@mwetter
Refactored guard of division against zero to avoid chattering
2e88f1c 
For #3106
@mwetter mwetter mentioned this issue Sep 9, 2022
Merged
mwetter added a commit that referenced this issue Sep 14, 2022
@mwetter @JayHuLBL
Refactored guard of division against zero to avoid chattering in mult…
b3bc444 
…izone VAV system of Guideline36 (#3107)

* Refactored guard of division against zero to avoid chattering

For #3106

* full path, change line, removed empty line

Co-authored-by: JayHuLBL <jianjunhu@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
Release 9.1
1 participant
@mwetter