Bugs for the models in cooling capacity calculator model

[lambtt]

Describe the bug
Model 1. Buildings.Fluid.HeatExchangers.DXCoils.BaseClasses.CoolingCapacityWaterCooled
Model 2. Buildings.Fluid.HeatExchangers.DXCoils.BaseClasses.PartialCoolingCapacity
Some codes for these two models seem to have problems.
Screenshots
For Model 1, it seems the water mass flow, ffCon should have been used in Cooling capacity modification factor as a function of water flow fraction at the condenser, but it didn't. And it seems the ffConMin should be replaced with ffConMax.

For Model 2, it seems there is the same issue as Model 1.

Version

• Modelica Buildings Library: [9.0.0]
• Modelica simulation environment: Dymola 2023
• Operating system: Windows 10

Additional context
I did the curve fitting (different temperatures and different flow rates) for the heat pump in our lab and found the results could not be matched. I copied Models 1 and 2 and modified the codes. Finally, the results could be matched.

The performance curve (Buildings.Fluid.HeatExchangers.DXCoils.WaterCooled.Examples.PerformanceCurves.Curve_I) in Example (Buildings.Fluid.HeatExchangers.DXCoils.WaterCooled.Examples.VariableSpeed) uses a constant modification factor for capFunFF, capFunFFCon, EIRFunFF, and EIRFunFFCon. I'm wondering if maybe that's the reason the bugs above didn't come up in the Example.

[mwetter]

Thanks for reporting. I will correct it on branch issue3065_dxCoilsPerformance

[lambtt]

Thanks for reporting. I will correct it on branch issue3065_dxCoilsPerformance

Thank you for your attention, Michael! We will keep following it! @mingzhe37

[mwetter]

@lambtt : Can you please check if #3147 addresses the issue.
Thanks.

[lambtt]

@mwetter : Michael, I have checked the code change and left a comment #3147 (comment). Hope it helps!