Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DX coil for heating #3288

Closed
mwetter opened this issue Mar 10, 2023 · 5 comments · Fixed by #3337
Closed

Add DX coil for heating #3288

mwetter opened this issue Mar 10, 2023 · 5 comments · Fixed by #3337
Assignees
@mwetter

Comments

@mwetter
Copy link
Member

mwetter commented Mar 10, 2023 •
edited
Loading

This issue is to add DX coil models for heating.

The development branch is issue3288_dxCoilHeating_renameCooledSource, and development is ongoing at https://github.com/terrancelu92/modelica-buildings/tree/dxcoil_heating_example
@mwetter mwetter self-assigned this Mar 10, 2023
@mwetter
Copy link
Member Author

mwetter commented Mar 10, 2023 •
edited
Loading

Items for discussion

  • Are coils for heating only, or switch-over?
  • Evaluate how to implement multi-speed and variable speed by adapting current base models.
  • Rename package from AirCooled to AirSource and WaterCooled to WaterSource (@mwetter to test change for Buildings 10.0.0)
  • Use weather bus weaBus to get source temperature and humidity rather than a real input signal.

mwetter added a commit that referenced this issue Mar 10, 2023
@mwetter
Renamed AirCooled to AirSource, and same for WaterCooled
42f670b 
For #3288
This was referenced Mar 10, 2023
Merged
Merged
@karthikeyad-pnnl
Copy link
Contributor

@mwetter Regarding the use of weather-bus to read secondary coil conditions: I confirmed that the current DX cooling component template for ctrl-flow uses a weatherbus to read the outdoor air/condenser-water temperature. Therefore, we should be able to use a weather bus input even on the coil baseclasses. Seen below: Buildings.Templates.Components.Coils.EvaporatorVariableSpeed from #1374.

image

mwetter added a commit that referenced this issue Mar 11, 2023
@mwetter
Renamed AirCooled to AirSource, and same for WaterCooled (#3289)
49ebc3b 
For #3288
@mwetter
Copy link
Member Author

mwetter commented Mar 11, 2023

@karthikeyad-pnnl : Great, thanks for checking and confirming this compatibility with the templates.

@karthikeyad-pnnl
Copy link
Contributor

karthikeyad-pnnl commented Mar 15, 2023 •
edited
Loading

@mwetter We had a couple of questions about the integration of the DX heating coil:

  • What is the required deadline for inclusion in Buildings library 10.0.0? Are we still planning to include this feature in it?
  • We are going to assume branch issue3288_dxCoilHeating_renameCooledSource as the base branch on which we will make the PR with the proposed changes. We would like to confirm it with you.

We will be target completion of the following tasks by 03/31/23:

  • Addition of partial baseclass that is common to both DX heating and cooling coil.
  • Addition of separate baseclasses specifically for DX heating and cooling coil each.
  • Addition of partial curve record baseclass that is common to both cooling and heating coil.
  • Addition of curve record baseclass for heating and cooling coil each.
  • Addition of complete class definitions for DX heating and cooling coil each.
  • Addition of validation model for DX heating coil.

mwetter added a commit that referenced this issue Mar 15, 2023
@mwetter
Renamed AirCooled to AirSource, and same for WaterCooled (#3290)
d1ae09e 
For #3288
@mwetter
Copy link
Member Author

mwetter commented Mar 15, 2023

@karthikeyad-pnnl : If all tasks are completed by 3/31 then I think we should be able to include it in 10.0.0.

Please use issue3288_dxCoilHeating_renameCooledSource for the base (I will change the note above and delete issue3288_dxCoilHeating)

@mwetter mwetter mentioned this issue Mar 15, 2023
Merged
mwetter added a commit that referenced this issue Mar 17, 2023
@mwetter
Renamed AirCooled to AirSource, and same for WaterCooled (#3295)
8255284 
For #3288
karthikeyad-pnnl pushed a commit to karthikeyad-pnnl/modelica-buildings that referenced this issue Apr 3, 2023
@mwetter @karthikeyad-pnnl
Renamed AirCooled to AirSource, and same for WaterCooled
a474eb3 
For lbl-srg#3288

Restructure the DX coil package to implement the DX heating coil

Modify the other models that are impacted by the structure change

Update SpaceCooling.mo

Update SingleSpeedDXHeating.mo

Change the curve record to disable some DX coil parameters for heating coil operation

Renamed files for validation activity

Renamed variables as per changes

Updated variable names in validation script to reflect changes in instance naming in class

Added simulate and plot script for example file for DX heating coil

Undo changes to validation script to facilitate easier comparison during unit test

Renamed dxCoi instances to dxCoo

Changed coil instance name as per updated class names

Updated unit test result

Added new unit test result files for DX heating coil

Renamed single speed example file

Updated file name for multistage DX cooling coil example

Renamed example file for multistage DX cooling coil

Updated instance name for coil calculations from dxCoo to dxCoi

Updated instance names for coil calculations blocks in validation/example scripts

Updated unit test results after updates to instance and class names

Updated documentation

Added validation case (PLR=1) for the DX heating coil

Added the validation case for PLR<1

Added the mos script for the validation cases

Updated class names to show use in both cooling and heating mode operation. Added classes for defrost energy calculations.

Updated validation model by removing hard-coded data tables

Added validation models for all 4 defrost mode combinations

Updated validation models and defrost calculations

Renamed class for multi-stage DX cooling coil

Updated class name for single speed DX cooling coil

Updated class name for variable speed DX cooling coil.

Changed class name for single speed DX heating coil

Changed validation model class name for single speed DX cooling coil

Updated class name for validation model for single speed DX cooling coil with variable PLR

Fixed changes to class name

Fixed issues with renaming

Updated validation model class names for DX heating coils

Removed two unused validation models

Updated data records

Updated example model for single speed DX heating coil

Updated validation models for DX heating coil

Updated blocks for defrost calculations

Updated instance names for coil capacity calculations

Updated instance names for coil capacity calculations

Updated baseclasses for DX coil model

Updated instance name related to coil capacity calculations

Updated formatting and documentation on validation model

Updated formatting and validation for DX heating coil validation models. Updated folder structure for validation data

Updated formatting and documentation

Updated documentation for types enumeration. Moved them to separate types package

Updated class name from CoolingCapacityAirCooled to CoilCapacityAirSource

Added documentation and validation script for PLRToPulse class. Updated instance names in all the validation models it is used in

Updated change log to indicate class name change

Updated instance names from cooCap to coiCap
@mwetter mwetter mentioned this issue Apr 11, 2023
Closed
mwetter pushed a commit that referenced this issue Apr 11, 2023
@karthikeyad-pnnl
Issue3288 dx coil heating rename cooled source (#3333)
db42577 
* Renamed AirCooled to AirSource, and same for WaterCooled (#3289)

For #3288

* Restructure the DX coil package to implement the DX heating coil
mwetter added a commit that referenced this issue Apr 11, 2023
@mwetter
Issue3288 dx coil heating rename cooled source (#3336)
8acbaf2 
* Renamed AirCooled to AirSource, and same for WaterCooled

For #3288

* Restructure the DX coil package to implement the DX heating coil

* Modify the other models that are impacted by the structure change
@mwetter mwetter mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwetter @karthikeyad-pnnl