Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange reference file to verify the results of the model Buildings.Controls.OBC.CDL.Routing.Validation.RealVectorReplicator #3852

Open
AndreaBartolini opened this issue Jun 5, 2024 · 3 comments

Comments

@AndreaBartolini
Copy link
Contributor

AndreaBartolini commented Jun 5, 2024

The model Buildings.Controls.OBC.CDL.Routing.Validation.RealVectorReplicator fails the verification with the reference file produced by Dymola for the following signals:

  • reaRep.u[1]
  • time

The first is connected to the output of a ramp generator, the second is the current simulation time.

I run the model in both Dymola 2024 and OpenModelica v1.24.0 and the signals listed above are as expected, the problem is in the reference file that seems to contain strange values (I get this values from the OpenModelica CI):
image
image

Can you please check the values in the original reference file?
Thanks in advance.

Keep @casella in the loop...

@mwetter
Copy link
Member

mwetter commented Jun 5, 2024

@AndreaBartolini I copied the line that starts with time from the file
https://simulationresearch.lbl.gov/ReferenceResults/modelica-buildings/master/Dymola/Buildings_Controls_OBC_CDL_Routing_Validation_RealVectorReplicator.txt
into the script:

import numpy as np
import matplotlib.pyplot as plt
time=[0e+00, 2.000000094994903e-03, ...]
plt.plot(time)
plt.show()

and got the plot below.
image
I see nothing wrong with the data.

Similarly if I plot time and reaRep.u[1]:

image

@AndreaBartolini
Copy link
Contributor Author

AndreaBartolini commented Jun 6, 2024

@mwetter thanks for the cross check, we will check the reference files used in the CI.
@casella , who can do the cross check with the files indicated in #3852 (comment) ?

@casella
Copy link
Contributor

casella commented Jun 6, 2024

I'll open a ticket about that on the OMC issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants