Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong assert in Chillers.Carnot #468

Closed
mwetter opened this issue Nov 25, 2015 · 0 comments · Fixed by #469
Closed

wrong assert in Chillers.Carnot #468

mwetter opened this issue Nov 25, 2015 · 0 comments · Fixed by #469
Assignees
Labels
Milestone

Comments

@mwetter
Copy link
Member

mwetter commented Nov 25, 2015

In the initial equation section of Chillers.Carnot, the assert statement

 assert(abs(Buildings.Utilities.Math.Functions.polynomial(
         a=a, x=y)-1) < 0.01, "Efficiency curve is wrong. Need etaPL(y=1)=1.");

should be

 assert(abs(Buildings.Utilities.Math.Functions.polynomial(
         a=a, x=1)-1) < 0.01, "Efficiency curve is wrong. Need etaPL(y=1)=1.");

because the test is for full load, e.g., y=1.

@mwetter mwetter added the bug label Nov 25, 2015
@mwetter mwetter self-assigned this Nov 25, 2015
@mwetter mwetter added this to the Release 3.0 milestone Nov 25, 2015
mwetter added a commit that referenced this issue Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant