Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmatched dimensions in Buildings.Fluid.Storage.StratifiedEnhancedInternalHex #531

Closed
rubenbaetens opened this issue Jun 20, 2016 · 2 comments · Fixed by #533
Closed

Unmatched dimensions in Buildings.Fluid.Storage.StratifiedEnhancedInternalHex #531

rubenbaetens opened this issue Jun 20, 2016 · 2 comments · Fixed by #533
Assignees
Labels
Milestone

Comments

@rubenbaetens
Copy link

rubenbaetens commented Jun 20, 2016

When using Buildings.Fluid.Storage.StratifiedEnhancedInternalHex i constantly get errors for the connection of the internal hex to the tank. e.g.

  Buildings.Fluid.Storage.StratifiedEnhancedInternalHex tan(hTan=1.2, hHex_a=0.1, hHex_b=0.3, nSeg=12, hexSegMult=2)

gives

Unmatched dimension in connect(tan.indTanHex.port[5], tan.heaPorVol[13]);
Unmatched dimension in connect(tan.indTanHex.port[6], tan.heaPorVol[13]);

but at first sight i can't figure out the error.

@rubenbaetens
Copy link
Author

Note, the error only occurs when nSegHexTan > 1.

@mwetter mwetter added the bug label Jun 23, 2016
@mwetter mwetter self-assigned this Jun 23, 2016
@mwetter mwetter added this to the Release 4.0 milestone Jun 23, 2016
@mwetter
Copy link
Member

mwetter commented Jun 23, 2016

@rubenbaetens
The problem occurs because the loop that connects the heat exchanger and the fluid volumes in incremented in the wrong direction if hHex_a < hHex_b.
I will correct it for the next release.

mwetter added a commit that referenced this issue Jun 23, 2016
Added bug fix and validation case for #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants