Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small stylistic/convention issue in Controls.SetPoints.Table #555

Closed
eshmoylova opened this issue Aug 25, 2016 · 2 comments
Closed

Small stylistic/convention issue in Controls.SetPoints.Table #555

eshmoylova opened this issue Aug 25, 2016 · 2 comments

Comments

@eshmoylova
Copy link

In Controls.SetPoints.Table there is a parameter nCol, commented as "Number of columns." It is used as the first dimension of the two-dimensional array offsetVector, which in itself is a confusing name. A two-dimensional array in Modelica is equivalent to a matrix. In a matrix the first dimension refers to the number of rows, and the second dimension refers to a number of columns. So it would be more correct to refer to nCol as nRow, number of rows.

@mwetter
Copy link
Member

mwetter commented Aug 25, 2016

@eshmoylova
Thanks for reporting. I will look at it next week when I am back in the office again.

@mwetter
Copy link
Member

mwetter commented Aug 30, 2016

@eshmoylova . Thanks for the issue. This is now on the master

@mwetter mwetter closed this as completed Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants