Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid dip in energy at shallow incidence angle for solar collector #785

Closed
mwetter opened this issue May 31, 2017 · 4 comments · Fixed by #787
Closed

avoid dip in energy at shallow incidence angle for solar collector #785

mwetter opened this issue May 31, 2017 · 4 comments · Fixed by #787

Comments

@mwetter
Copy link
Member

mwetter commented May 31, 2017

The solar collector model has a dip at shallow incidence angles due to the incidence angle modifier, see figure below.

image
mwetter added a commit that referenced this issue May 31, 2017
@mwetter
Changed regularization for #785
5a3fa61
@mwetter
Copy link
Member Author

mwetter commented May 31, 2017

The above commit should solve this issue. What remains before merging it is to verify that the validation above is now correct.

@Mathadon
Copy link
Contributor

screen shot 2017-05-31 at 16 59 03
Results are clearly better :)

@mwetter
Copy link
Member Author

mwetter commented Jun 1, 2017

@Mathadon : Every morning there is a large spike, presumably when there is no flow rate. Is this because the pump switches on too late in your model?
Evening hours look good now.

@Mathadon
Copy link
Contributor

Mathadon commented Jun 1, 2017

The pump only turns on when a certain temperature threshold is obtained. This control loop is not modelled and therefore the pump turns on too early/late. This causes the water to heat up more/less than in the measurements.

mwetter added a commit that referenced this issue Jun 1, 2017
@mwetter
Update release notes and info section
0b7db76 
For #785
@mwetter mwetter mentioned this issue Jun 1, 2017
Merged
jelgerjansen added a commit to jelgerjansen/modelica-buildings that referenced this issue Jan 2, 2024
@jelgerjansen
Remove references to setting IAM=0 for angles>60° since this was remo…
cc22a5a 
…ved by the changes discussed in issue lbl-srg#785
mwetter added a commit that referenced this issue Mar 14, 2024
@mwetter @jelgerjansen
Issue3604 solar collectors (#3710)
41119fb 
* Add absorber area to Types.Area

* Creating separate data records for ASHRAE93 and EN12975 solar collectors, both extending from a partial record containing common inputs.
Furthermore, a parameter eta_0 is added to the EN12975 record to distinguish from y_intercept which is used in ASHRAE93.

* Use eta_0 instead of y_intercept for EN12975 rating data

* Update documentation

* Clarify which temperature difference is needed for dT_nominal

* Update UsersGuide

* Remove references to setting IAM=0 for angles>60° since this was removed by the changes discussed in issue #785

* Run dos2unix

* Remove G_nominal from the data record since this is not used any more, add default value for dT_nominal, and update symbols to correspond to the most recent version of EnergyPlus

* Update UsersGuide

* Allow other ways of defining the thermal capacity of the solar collector and include revisions section in data records

* Make the documentation section of models more consistent
Update the documentation section
Update symbols in equations and documentation (eg. a1 and a2 instead of C1 and C2) to be consistent with datasheets

* Remove dT_nominal from data record and models since this is not used by the model

* Fix typo

* Remove QLos_nominal and cp_default from PartialHeatLoss model since these are not used

* Make PartialSolarCollector a partial model

* Remove ATyp and corresponding enumeration since this is not used in the model.
The User's Guide is updated however to point out that the user should pick the performance parameters for the chosen area.

* Remove Types.Area

* Remove minimum number of segments requirement

* Update positioning in graphical view

* Revert name changing of QLos to heaLos

* Change name of heaGai to QGai to be consistent with QLos

* Remove G_nominal from PartialHeatLoss

* Remove m_flow_nominal from PartialHeatLoss (not used any more)

* Use replaceable for performance parameters

* Remove all data concerning concentrating solar collectors

* Update existing data records according to newest data record format

* Remove ATyp from existing data records

* Temporarily add C=0 in data records to avoid errors in examples

* Update Buildings.Fluid.SolarCollectors.Controls

* Update Buildings.Fluid.SolarCollectors.Controls (2)

* Update Fluid.SolarCollectors.BaseClasses.Examples (including scripts) and add ASHRAEHeatLoss model

* Update Fluid.SolarCollectors.Examples

* Update Fluid.SolarCollectors.Validation

* Calculate the equivalent volume of the solar collector based on CTyp

* Add documentation to data record which clarifies the use of CTyp and C,V, and mDry

* Change data of ASHRAEHeatLoss unit test back to initial

* Fix amplitudes in ASHRAEHeatLoss example

* Remove modifier of C (doesn't exist any more) in EN12975_Series

* Update reference results

* Reverted reference results that only have date change

* Allow array system configuration and change nominal mass flow rate and pressure drop accordingly

* Explain array configuration in user guide

* Add validation model and script for array configuration

* Calculate IAM using experimental data from data sheets in combination with cubic polynomial splines.

* Change parameters of generic data record

* Update existing data records

---------

Co-authored-by: jelgerjansen <jelgerjansen@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue785 solar collector lbl-srg/modelica-buildings
2 participants
@mwetter @Mathadon