Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch in weather data reader #8

Closed
mwetter opened this issue Mar 3, 2013 · 5 comments
Closed

Add switch in weather data reader #8

mwetter opened this issue Mar 3, 2013 · 5 comments

Comments

@mwetter
Copy link
Member

mwetter commented Mar 3, 2013

Add switch in weather data so that it can read real weather data or user specified input

@mwetter
Copy link
Member Author

mwetter commented Mar 3, 2013

[mwetter] The switch should allow separate specification of
PAtm (already implemented)
TDryBul
relHum
winSpe
winDir
HGloHor
HDifHor

@mwetter
Copy link
Member Author

mwetter commented Mar 3, 2013

[wzuo] All the switches are added.

@mwetter
Copy link
Member Author

mwetter commented Mar 3, 2013

[mwetter] The model implementation is not complete and was not sufficiently tested and revised. The following issues need to be addressed:


We never use Modelica.SIunits.Temp_C. ALWAYS use Modelica.SIunits.Temperature.


The same applies to relative humidity, which is between 0 to 1, not 0 to 100. Otherwise, we will make mistakes if we mix conventions.


Also, never put units or ranges in the comment: Use unit="1" instead of "Relative humidity in [0-100](used if relHum=Parameter)".


Use units for all input and output signals. See for example the Buildings.Fluid.Sensors. A proper declaration is
Modelica.Blocks.Interfaces.RealInput TDryBul_in(
final quantity="Temperature",
final unit = "K", min=0,
displayUnit = "degC")
instead of
Modelica.Blocks.Interfaces.RealInput TDryBul_in


If parameters can conditionally be disabled, then they must have a value. Otherwise, a tool may complain about missing parameters.


Several typos in the comment need to be fixed (such as for 'temperature' and 'atmospheric pressure').


Don't use
import Buildings.BoundaryConditions.Types.DataSource;
import Buildings.BoundaryConditions.Types.SkyTemperatureCalculation;
as this is dangerous because everything gets in scope. Use instead
import ds = Buildings.BoundaryConditions.Types.DataSource;
...


Fix the comments: There is no physical quantity "Global diffuse radiation": It is either global or diffuse, but not global diffuse. Make sure it is correctly used in the model.


The statement
parameter Modelica.SIunits.Conversions.NonSIunits.Angle_deg winDir
"Wind direction (used if winDir=Parameter)"
annotation (Evaluate=true, Dialog(group="Data source"));
must be fixed. We NEVER use NonSIunits. Use SIUnits instead and set the displayUnit attribute to the required unit.

@mwetter
Copy link
Member Author

mwetter commented Mar 3, 2013

[wzuo] 1. There is no unit "percentage" in Modelica. Which unit should we use?

  1. For "import ds = Buildings.BoundaryConditions?.Types.DataSource?;"
    I remember that we should use the full path instead of alias. Is that right?

@mwetter
Copy link
Member Author

mwetter commented Mar 3, 2013

[wzuo] The following changes have been made:

  1. All user input files and parameters must use SI units. We add models to convert all the non-SI units in TMY3 data before they connect to switches.
  2. Delete the
    import Buildings.BoundaryConditions?.Types.DataSource?;
    import Buildings.BoundaryConditions?.Types.SkyTemperatureCalculation?;

We do not use
import ds = Buildings.BoundaryConditions?.Types.DataSource?;
Because Dymola's graphic interface can not automatically transfer the code.

  1. Change the "global diffuse radiation" to "diffuse horizontal radiation"

@mwetter mwetter closed this as completed Mar 3, 2013
JingWang-CUB pushed a commit to JingWang-CUB/modelica-buildings that referenced this issue May 29, 2020
caryfaulkner pushed a commit to caryfaulkner/modelica-buildings that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant