-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch in weather data reader #8
Comments
[mwetter] The switch should allow separate specification of |
[wzuo] All the switches are added. |
[mwetter] The model implementation is not complete and was not sufficiently tested and revised. The following issues need to be addressed: We never use Modelica.SIunits.Temp_C. ALWAYS use Modelica.SIunits.Temperature. The same applies to relative humidity, which is between 0 to 1, not 0 to 100. Otherwise, we will make mistakes if we mix conventions. Also, never put units or ranges in the comment: Use unit="1" instead of "Relative humidity in [0-100](used if relHum=Parameter)". Use units for all input and output signals. See for example the Buildings.Fluid.Sensors. A proper declaration is If parameters can conditionally be disabled, then they must have a value. Otherwise, a tool may complain about missing parameters. Several typos in the comment need to be fixed (such as for 'temperature' and 'atmospheric pressure'). Don't use Fix the comments: There is no physical quantity "Global diffuse radiation": It is either global or diffuse, but not global diffuse. Make sure it is correctly used in the model. The statement |
[wzuo] 1. There is no unit "percentage" in Modelica. Which unit should we use?
|
[wzuo] The following changes have been made:
We do not use
|
Added start value for efficiency
Add switch in weather data so that it can read real weather data or user specified input
The text was updated successfully, but these errors were encountered: