Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDL changes #933

Closed
5 tasks
mwetter opened this issue Sep 13, 2017 · 5 comments · Fixed by #941
Closed
5 tasks

CDL changes #933

mwetter opened this issue Sep 13, 2017 · 5 comments · Fixed by #941
Assignees
Milestone

Comments

@mwetter
Copy link
Member

mwetter commented Sep 13, 2017

Based on TAG feedback, implement the following (non-backward) compatible changes:

  • Remove Continuous.Add3 and Integer.Add3 blocks, and instead add an Integer.MultiSum with parameter Integer k[nu]=fill(1, nu) "Input gains"; (there is already a Continuous.MultiSum).
  • Rename SignalRanker to Rank (or better, Sort) as all blocks operate on signals anyway. Sort may be better as it sorts the signal.
  • Remove Continuous.Sum as this does the same as Continuous.MultiSum.
  • Add Continuous.Round that rounds the input to n digits, and remove Continous.Truncation as this can be done with the Round block.
  • Add Continuous.MultiMin and Continuous.MultiMax and remove the current MinMax. Reason: often one only needs either the min or the max, but not both.
@mwetter mwetter added this to the Release 5.0 milestone Sep 13, 2017
@JayHuLBL JayHuLBL self-assigned this Sep 14, 2017
JayHuLBL added a commit that referenced this issue Sep 14, 2017
@JayHuLBL
Copy link
Contributor

@mwetter Following changes have been done in branch issue933_CDL_changes:

  • removed Continuous.Add3, Integers.Add3;
  • created Integers.MultiSum;
  • renamed Continuous.SignalRanker to Continuous.Sort;
  • removed Continuous.MinMax;
  • added Continuous.MultiMin and Continuous.MultiMax;
  • removed Continuous.Trunction ;
  • added Continuous.Round;

Regarding Continuous.Sum and Continuous.MultiSum, they are different. As for Sum, its input can be a vector with the size being parameterized. The MultiSum receiving inputs by drawing lines and its number of inputs is changing with the connected line. We'd probably keep both blocks.

@mwetter
Copy link
Member Author

mwetter commented Sep 14, 2017

I agree we should keep both, MultiSum and Sum. Then, blocks that automatically size the parameter nin should have the name Multi*. We are consistent in this respect with MultiSum and MultiAnd

@JayHuLBL
Copy link
Contributor

I just realized that we can use MultiSum to replace Sum. I will update it now.

@mwetter
Copy link
Member Author

mwetter commented Sep 15, 2017 via email

@JayHuLBL
Copy link
Contributor

JayHuLBL commented Sep 15, 2017 via email

JayHuLBL added a commit that referenced this issue Sep 15, 2017
JayHuLBL added a commit that referenced this issue Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants