-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDL changes #933
Comments
…enamed SignalRanker to Sort #933 [ci skip]
@mwetter Following changes have been done in branch
Regarding |
I agree we should keep both, |
I just realized that we can use |
Will the parameter `nin` be configured correctly if a vector is connected
graphically?
…On Thu, Sep 14, 2017 at 5:11 PM, Jianjun Hu ***@***.***> wrote:
I just realized that we can use MultiSum to replace Sum. I will update it
now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABRHuDNjcPO74INISwDrxLxJd5bjL4-9ks5sicDNgaJpZM4PWtfB>
.
|
Yes, the parameter `nin` will automatically be configured according to the
vector size.
On Thu, Sep 14, 2017 at 5:31 PM, Michael Wetter <notifications@github.com>
wrote:
… Will the parameter `nin` be configured correctly if a vector is connected
graphically?
On Thu, Sep 14, 2017 at 5:11 PM, Jianjun Hu ***@***.***>
wrote:
> I just realized that we can use MultiSum to replace Sum. I will update it
> now.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#933#
issuecomment-329642225>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/
ABRHuDNjcPO74INISwDrxLxJd5bjL4-9ks5sicDNgaJpZM4PWtfB>
> .
>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWZ1UQIuWEnrZqCWQNgfufkmivpUtgwyks5sicVzgaJpZM4PWtfB>
.
--
--------------------------------------
Jianjun Hu, PhD
Simulation Research Group
Lawrence Berkeley National Laboratory
1 Cyclotron Road, MS 90R3147
Berkeley, CA 94720
email: JianjunHu@lbl.gov <TSNouidui@lbl.gov>
http://simulationresearch.lbl.gov
----------------------------------------
|
Based on TAG feedback, implement the following (non-backward) compatible changes:
Continuous.Add3
andInteger.Add3
blocks, and instead add anInteger.MultiSum
withparameter Integer k[nu]=fill(1, nu) "Input gains";
(there is already aContinuous.MultiSum
).SignalRanker
toRank
(or better,Sort
) as all blocks operate on signals anyway.Sort
may be better as it sorts the signal.Continuous.Sum
as this does the same asContinuous.MultiSum
.Continuous.Round
that rounds the input ton
digits, and removeContinous.Truncation
as this can be done with theRound
block.Continuous.MultiMin
andContinuous.MultiMax
and remove the currentMinMax
. Reason: often one only needs either the min or the max, but not both.The text was updated successfully, but these errors were encountered: