-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1298 linear actuators #1430
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update VAV model.
…into issue1298_linearActuators
…into issue1298_linearActuators
…into issue1298_linearActuators
…into issue1298_linearActuators
Close as it is now addressed in issue1188_dampersRefactor of IBPSA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly closes #1298 (the valves components still need to be updated with the same logic).
(Corresponding issue in IBPSA library: #1188)
VAVBoxExponential
is retired. The option for the fixed resistance has been integrated intoExponential
. (A conversion script is attached.)dp_nominal
inExponential
andPressureIndependent
has been replaced bydpExp_nominal
anddpDam_nominal
(modification also automated by the above script). The motivation is to restrict the use ofdp_nominal
to the nominal pressure drop at the model boundaries (which is used byPartialDamperExponential
in the homotopy initialization cf.dp/dp_nominal_pos
). In the master branch, it is indeed the case forExponential
, it might be the case forVAVBoxExponential
ifdp_nominalIncludesDamper==True
and it is never the case forPressureIndependent
. Introducing the new parameters ensures consistency (and appears to be the best way to mergeVAVBoxExponential
intoExponential
properly).k0
andk1
are used inPartialDamperExponential
motivated by https://antoinegautier.github.io/plots/Actuators.html#/6.PressureIndependent
:m_flow
/dp
while ensuring a bounded error (approximately) is illustrated here https://antoinegautier.github.io/plots/Actuators.html#/4. It relies on 1) an intermediarydp_lim
variable limiting the linear domain wherem_flow = y_actual * m_flow_nominal + cregul *...
, 2) an extended domain for the upper spline interpolation and 3) a leakage flow supposed to be mainly turbulent (to limit the domain where the 2 flow functions are not inverse from each other). The resulting flow characteristics is also part of the updated example seeBuildings/Fluid/Actuators/Dampers/Examples/Damper.mo
casepreIndCha
. The impact on the test case described in Implement linearization algorithm for damper and valve models #1298 is presented in https://antoinegautier.github.io/plots/Actuators.html#/2/1.y=0
anddp
transitions from negative to positive values is handled through a threshold value (2%) of the input signal below which the opening is forced to zero.Note:
PressureIndependent
might fail to simulate without changing some parameters values to be consistent with the exponential damper characteristics that is now used by the model to compute the opening (typically models inBuildings/Examples/VAVReheat
had a too high nominal pressure drop with a too low nominal velocity: those parameters have been changed manually, the script mentioned above does not handle that modification).Exponential
orMixingBox
damper models. This is unexpected but needed due to small numerical effects yielded by the modification of the model structure only (as one can see in the modified translation statistics): the governing equations are unchanged and it has been verified that all the parameters (including the protected ones) have the same value between the master and the development branch (except fordp_nominal
as explained before but that should not impact the simulation after initialization).Buildings_Examples_DualFanDualDuct_ClosedLoop.txt
Buildings_Examples_HydronicHeating_TwoRoomsWithStorage.txt
Buildings_Applications_DataCenters_DXCooled_Examples_DXCooledAirsideEconomizer.txt
Buildings.Examples.DualFanDualDuct.ClosedLoop
fails to simulate with JModelica for the same reason. I will notify Modelon (Agnes). In the meantime simulation is excluded from JModelica regression tests.Conversion script:
VAVBoxExponentialRefactor.py.txt