New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1853 lim partype #1859

Merged

mwetter merged 11 commits into master from issue1853_limPartype

Apr 3, 2020

Contributor

JayHuLBL commented Mar 28, 2020

corrected parameter declarations to avoid use type like Modelica.SIunits.xxx

This closes #1853.

JayHuLBL added 4 commits

March 27, 2020 15:30


          cleaned parameter declarations in package AHUs.MultiZone, #1853 [ci s…

aabfacc

…kip]


          cleaned parameter declarations in package AHUs.SingleZone, #1853 [ci …

306307f

…skip]


          cleaned parameter declarations in package Generic, #1853 [ci skip]

21358a1


          cleaned parameter declarations in package TerminalUnits, #1853 [ci skip]

2e887b3

JayHuLBL added the OpenBuildingControl label

JayHuLBL requested a review from mwetter

March 28, 2020 05:16

JayHuLBL self-assigned this

JayHuLBL added 7 commits

March 27, 2020 22:18


          dummy commit to run CI test, #1853

904a360


          added Evaluate=true attribute to avoid translation error in OCT, #1853

c76c1da


          Merge branch 'master' into issue1853_limPartype

9b1a8b2


          avoided using evaluate=true, #1853

0e3cdf8


          updated G36 reference results, #1853

3985ef7


          updated single zone G36 reference result, #1853

a42f9b4


          corrected parameter declaration to avoid OCT translation error, #1853

25f3e25

Contributor Author

JayHuLBL commented Apr 3, 2020

in package Buildings.Controls.OBC.ASHRAE.G36_PR1, eliminated usage of Evaluate=true annotation in parameter declaration.

@mwetter It's ready for your review. After this PR being merged, I will then address potential issue in PR #1862.

mwetter merged commit b91cbd7 into master

mwetter deleted the issue1853_limPartype branch

April 3, 2020 17:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment