Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated and Created CDL blocks #2872

Merged
merged 24 commits into from
Feb 3, 2022
Merged

Updated and Created CDL blocks #2872

merged 24 commits into from
Feb 3, 2022

Conversation

JayHuLBL
Copy link
Contributor

@JayHuLBL JayHuLBL commented Feb 1, 2022

This closes #2865.

  • added new CDL blocks, renamed existing blocks, and moved blocks to Obsolete package, see Modify CDL blocks based on ASHRAE 231P discussion #2865.
  • renamed Dymola command script (.mos) file, renamed the reference results and the OpenModelica script
  • created Dymola conversion script
  • updated release note

@JayHuLBL JayHuLBL self-assigned this Feb 1, 2022
mwetter
mwetter reviewed Feb 2, 2022
View reviewed changes
Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayHuLBL
Can you please address the two inline comments. Then this is ready to merge when the tests pass.

@mwetter
Copy link
Member

mwetter commented Feb 3, 2022

@JayHuLBL : FYI, I am working on resolving the failed test which needs a patch in BuildingsPy

@mwetter mwetter enabled auto-merge (squash) February 3, 2022 18:11
@mwetter mwetter merged commit 129640e into master Feb 3, 2022
@mwetter mwetter deleted the issue2865_cdl_updates branch February 3, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter mwetter left review comments

Assignees

@JayHuLBL JayHuLBL

Labels
None yet
Projects
OpenBuildingControl
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify CDL blocks based on ASHRAE 231P discussion
2 participants
@JayHuLBL @mwetter