Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all NLTK with scikit-learn #35

Closed
marksverdhei opened this issue Mar 17, 2021 · 1 comment · Fixed by #52 or #54
Closed

Replace all NLTK with scikit-learn #35

marksverdhei opened this issue Mar 17, 2021 · 1 comment · Fixed by #52 or #54
Labels
approved Suggestion approved enhancement New feature or request
Projects
Website

Comments

@marksverdhei
Copy link
Collaborator

marksverdhei commented Mar 17, 2021 •
edited

NLTK is an old fashioned, awkward (imo). I think we should opt for a more modern classifier API. scikit learn is more modern and elegant. I think we should use this for the naive bayes (and possibly other) classifiers
@marksverdhei marksverdhei added awaiting approval Suggestion awaits approval backend enhancement New feature or request labels Mar 17, 2021
@marksverdhei marksverdhei added this to Up for approval in Website via automation Mar 17, 2021
@LBlend LBlend removed the backend label Dec 12, 2021
@LBlend
Copy link
Owner

LBlend commented Dec 12, 2021

Having never used SciKit-learn, I can't attest to this. However I trust you on this and think we should go ahead with it in the rewrite

@LBlend LBlend added approved Suggestion approved and removed awaiting approval Suggestion awaits approval labels Dec 12, 2021
@LBlend LBlend moved this from Up for approval to To do in Website Mar 13, 2022
@marksverdhei marksverdhei mentioned this issue Apr 3, 2022
Merged
@LBlend LBlend linked a pull request Apr 3, 2022 that will close this issue
Migrate to sklearn #52
Merged
@LBlend LBlend mentioned this issue Apr 5, 2022
Merged
@LBlend LBlend closed this as completed in #54 Apr 5, 2022
Website automation moved this from To do to Done Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved Suggestion approved enhancement New feature or request
Projects
Website
  
Done
Milestone
No milestone
2 participants
@LBlend @marksverdhei