Create Login and Switch provider components #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These components are styling independant so apps can use them if the default button components don't cover the needed use cases.
|
No tests yet since I didn't want to spend to much time on this, and I don't know how to do all the auth mocking yet either 馃槵 |
erikap
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #4 (comment)
These components are styling independent so apps can use them if the default button components don't cover the needed use cases. I also used the provider component to "reimplement" the button components already.
I didn't create a component for the logout button since I think it should be removed 馃槃.
I still think that keeping the addon styling independant is the best way forward but shipping it this way will make that transition easier since it's not a breaking change. The buttons can also be deprecated first to make it clear that change is coming.