This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Use editor debug component instead of duplicated code (see GN-3152) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 26, 2022 23:18
Removed the dummy app code that is now a duplicate of the rdfa-editor debug component (see issue GN-3152) and used that instead.
Forgot to remove the unused code in previous commit.
Class definition wasn't necessary, because it is already defined on the debug component itself.
The newer version of the editor correctly handles the plugins. This was not the case in 0.50.0-beta.5 yet.
Changes after a final rebuild of the project, now with the public beta release of the editor (beta 6).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin now uses the debug component from the ember-rdfa-editor instead of duplicating code. As of now this depends on release 0.50.0-beta.6 of the editor.
Was tested, but please, test the build and its dependencies as a double check.