Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-appuniversum #171

Merged
merged 10 commits into from
Nov 4, 2021
Merged

Add ember-appuniversum #171

merged 10 commits into from
Nov 4, 2021

Conversation

Dietr
Copy link
Contributor

@Dietr Dietr commented Oct 21, 2021

Add ember-appuniversum as dependency so we can remove the duplicate components in plugins over time.

  • simplified the theming: bundled all variables in one _s-theme file
  • seperated the custom components in a file so we can only load these in Gelinkt Notuleren
  • added some ember-appuniversum variables so we maintain the say style (purple primary color)

Next steps:

Open questions:

  • how do we best handle different versions of ember-appuniversum in GN and ember-rdfa-editor / plugins?

@nvdk
Copy link
Member

nvdk commented Oct 29, 2021

On the open questions:

  • plugins should specify app universum as a peerdependency and be as lenient as possible on version requirements.

@nvdk
Copy link
Member

nvdk commented Oct 29, 2021

@Dietr I'm guessing we will also need to update https://github.com/lblod/frontend-embeddable-notule-editor

Copy link
Member

@nvdk nvdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the strong tag doens't look bold anymore in this branch. other than that I found no immediate issues.

@abeforgit
Copy link
Member

On the open questions:

* plugins should specify app universum as a peerdependency and be as lenient as possible on version requirements.

Shouldn't the editor itself then also specify appuniversum as a peerdep?

@abeforgit abeforgit merged commit 2d432f9 into development Nov 4, 2021
@abeforgit abeforgit deleted the feature/use-appuniversum branch November 4, 2021 10:08
@abeforgit abeforgit added the enhancement New feature or request label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants