lazy load uittreksels #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a somewhat quick hack and isnt the prettiest, but it should do what it's supposed to do: allow users to only load the data the need and work with that. Currently still has some rendering issues to iron out.
nvdk
force-pushed
the
feature/lazy-loading-extract
branch
from
ddbdd86
to
a7a92ba
Compare
lagartoverde
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Looks good, some remarks I can fix if you want:
- Doesn't seem obvious at first that you have to click the name of the agendapoint in order to publish it, maybe we should add a button on the table or something to make it clearer
- The searching works but takes some time, maybe we should have a loading icon or something
- Agendapoints are 0 based on the index, I think they should be 1 based
- There's a dot on top of the publish screen, due to the
<li>container
…ove list from timelinestep
Dietr
approved these changes
Aug 24, 2021
nvdk
commented
Aug 24, 2021
|
|
||
| export default class MeetingsPublishUittrekselsShowRoute extends Route { | ||
| async model(params) { | ||
| console.log(params); |
There was a problem hiding this comment.
stray debugging statement should go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a somewhat quick hack and isnt the prettiest, but it should do what it's
supposed to do: allow users to only load the data the need and work with that.
Currently still has some rendering issues to iron out.