Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a warning to attachment overview if no decisions were found #205

Merged
merged 4 commits into from Oct 6, 2021

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Oct 6, 2021

warningexample
An attempt to make it a bit more clear how it works.

@Dietr not sure about the placement of the warning (currently inside the table and feels a bit messy).
In general: might consider just converting this to a regular info box and always show it?

@nvdk nvdk force-pushed the enhancement/warn-no-decisions-found branch from 8bea8bc to a237f58 Compare October 6, 2021 10:30
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there's a typo ;)

translations/en-us.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@Dietr Dietr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer not to have this inside the table so changed the position of the warning to the bottom of the screen.

@nvdk nvdk merged commit b312c83 into development Oct 6, 2021
@nvdk nvdk deleted the enhancement/warn-no-decisions-found branch October 6, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants