Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the template required when creating an agendapoint #247

Merged
merged 2 commits into from Mar 3, 2022
Merged

make the template required when creating an agendapoint #247

merged 2 commits into from Mar 3, 2022

Conversation

nvdk
Copy link
Member

@nvdk nvdk commented Mar 3, 2022

No description provided.

@nvdk nvdk added the enhancement New feature or request label Mar 3, 2022
lagartoverde
lagartoverde requested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@lagartoverde lagartoverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-03-03 at 15 25 05

Code looks good and it works, but I think we should add the required tag in the UI when creating the agendapoint

benjay10
benjay10 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@benjay10 benjay10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work correctly!

@nvdk nvdk merged commit 24e7b32 into development Mar 3, 2022
@nvdk nvdk deleted the enhancement/make-template-obligatory branch March 3, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagartoverde lagartoverde lagartoverde requested changes

@benjay10 benjay10 benjay10 approved these changes

@abeforgit abeforgit Awaiting requested review from abeforgit

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nvdk @benjay10 @lagartoverde