Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter based on validThrough property #333

Conversation

lagartoverde
Copy link
Contributor

First of all this depends on lblod/reglement-publish-service#5 so we should wait for that to be merged and deployed, but I created the PR so we can start a little discussion.
I did the most basic thing, if the reglement has an expiration date not show it, I was thinking on filtering based on the ones that are still valid (even thought we don't really set this validthrough date in the future, we just set it to today when we delete in the regulatory statements app). This would be more semantically correct, but also would bring the question: "Do we want to allow the user to include a template that will expire tomorrow, in the next week...?", I think that for the moment is better to leave it like this and improve the flow in the future, but it's open for discussion

@abeforgit
Copy link
Member

I would say no matter what we do, I would compare the dates. Like you said that should have the same effect since we're only setting current date when deleting, but just imagine we come back to this in 2 months time and see a property called "validThrough", we'd expect it to work as the name implies.

@abeforgit
Copy link
Member

abeforgit commented Oct 4, 2022

the pr you mentioned is now merged and deployed on dev

@abeforgit abeforgit added the bug Something isn't working label Oct 4, 2022
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it just kinda doesn't work, deleted templates still show up

@abeforgit abeforgit changed the title Filter based on valid through Filter based on validThrough property Oct 4, 2022
@lagartoverde
Copy link
Contributor Author

Well it just kinda doesn't work, deleted templates still show up

It should work now I fixed a typo in the query, also there's a looong waiting time for the cache

@abeforgit
Copy link
Member

Well it just kinda doesn't work, deleted templates still show up

It should work now I fixed a typo in the query, also there's a looong waiting time for the cache

you can just go to the server and restart the sparql-cache service, that's what I've been doing

@abeforgit abeforgit self-requested a review October 5, 2022 10:41
Copy link
Member

@abeforgit abeforgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works now

@abeforgit abeforgit requested a review from nvdk October 5, 2022 10:42
@abeforgit abeforgit merged commit ffdd2a5 into feature/regulatory-statements Oct 5, 2022
@abeforgit abeforgit deleted the feature/filter-based-on-valid-throught branch October 5, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants