avoid saving editor document title without changes #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpoelma
approved these changes
Apr 17, 2023
abeforgit
requested changes
Apr 17, 2023
|
I added a "Saved" AuPill next to the title, that hides itself after 30s to show the user the title got saved. Double check the dutch translation, I don't know if "Gered" is correct here, "Opgeslagen" was also suggested by Deepl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves https://binnenland.atlassian.net/browse/GN-4208, I couldn't reproduce the issue on local while I can easily do it on dev and qa, so it must have been fixed by other PR in the meantime.
I solved the issue where you could save a title even if it was unchanged