Feature/acm login rebase

[nbittich]

No description provided.

[Windvis]

The button in the header needs to start the login flow as well:
https://github.com/lblod/frontend-contact-hub/blob/7ad7f711f513f9d738a1184b91f4dea36b538076/app/components/app-header.hbs#L21-L28

The problem is that the <AcmidmLogin> is hardcoded to show a primary button, which won't work in the header. Other apps create a compact version of the component instead, but I don't like that. I think the real solution would be to make the components more flexible instead. lblod/ember-acmidm-login#4 (comment)

Maybe we can simply hide the header button for now? I can do the work in the acmidm addon but I would like to discuss it with Niels first.

[nbittich]

The button in the header needs to start the login flow as well:
https://github.com/lblod/frontend-contact-hub/blob/7ad7f711f513f9d738a1184b91f4dea36b538076/app/components/app-header.hbs#L21-L28

The problem is that the <AcmidmLogin> is hardcoded to show a primary button, which won't work in the header. Other apps create a compact version of the component instead, but I don't like that. I think the real solution would be to make the components more flexible instead. lblod/ember-acmidm-login#4 (comment)

Maybe we can simply hide the header button for now? I can do the work in the acmidm addon but I would like to discuss it with Niels first.

probably better to hide it for now and check it later once Niels get back from holidays; maybe we can create a jira ticket for it ? also when Niels get back from holidays we could also eventually merge his PR and release a new version of the addon