-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade app to 3.20 #8
Conversation
aatauil
commented
Dec 21, 2020
•
edited
edited
- Already using correct syntax so only a ember-cli-update was needed ( v3.16 -> v3.20 )
I found a few errors while testing :
Could you have a look @aatauil ? Thanks ! |
Yeah so I merely ran @cecemel are these known issues by any chance? |
@claire-lovisa @aatauil @HugaertsDries It seems I cannot reproduce the issue on QA |
@aatauil @claire-lovisa @HugaertsDries unable to reproduce on QA:
|
@cecemel Not able to reproduce the refresh one on qa, but abe to reproduce the volgende / vorige one. We'd probably need to check what has been deployed on qa to spot the refresh issue, for the other one I don't know |
The Reset bug might be linked to Ember itself (emberjs/ember.js#19180), the related PR has only been merged in v3.24.0 |
No need for {{on 'click' null}. Suffices to just not define a click handler. Fixes lblod/frontend-toezicht-abb#8 (comment) reset error
Reset button error fixed in following PR lblod/ember-submission-form-fields#7 |
Yep thanks everyone. Make sure to merge this in both dev and master of the frontend. release and bump. and then add this to app-toezicht both master and development |