Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade app to 3.20 #8

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Upgrade app to 3.20 #8

merged 4 commits into from
Jan 19, 2021

Conversation

aatauil
Copy link
Member

@aatauil aatauil commented Dec 21, 2020

  • Already using correct syntax so only a ember-cli-update was needed ( v3.16 -> v3.20 )

@claire-lovisa
Copy link
Contributor

I found a few errors while testing :

  1. Vlabel user
  • Geldt tot [ 11.01.2019 , 12.01.2022 ] --> volgende --> vorige --> Uncaught TypeError: link is undefined
  1. Editeur
  • Same link error
  1. Lezer
  • Reset --> Attempted to create a log for a path reference, but no node exist for that reference

Could you have a look @aatauil ? Thanks !

@aatauil
Copy link
Member Author

aatauil commented Jan 12, 2021

I found a few errors while testing :

  1. Vlabel user
  • Geldt tot [ 11.01.2019 , 12.01.2022 ] --> volgende --> vorige --> Uncaught TypeError: link is undefined
  1. Editeur
  • Same link error
  1. Lezer
  • Reset --> Attempted to create a log for a path reference, but no node exist for that reference

Could you have a look @aatauil ? Thanks !

Yeah so I merely ran ember-cli-update --to 3.20 Since the previous version is v3.16 there should only be backwards compatible changes that have been made and should not have impacted the app. I tested the errors with the master branch and it gives the same issues. But I guess these errors should still be removed though

@cecemel are these known issues by any chance?

@cecemel
Copy link
Member

cecemel commented Jan 13, 2021

@claire-lovisa @aatauil @HugaertsDries It seems I cannot reproduce the issue on QA
Geldt tot [ 11.01.2019 , 12.01.2022 ] --> volgende --> vorige --> Uncaught TypeError: link is undefined

@cecemel
Copy link
Member

cecemel commented Jan 13, 2021

@aatauil @claire-lovisa @HugaertsDries unable to reproduce on QA:

Reset --> Attempted to create a log for a path reference, but no node exist for that referenc

@claire-lovisa
Copy link
Contributor

@cecemel Not able to reproduce the refresh one on qa, but abe to reproduce the volgende / vorige one. We'd probably need to check what has been deployed on qa to spot the refresh issue, for the other one I don't know

@claire-lovisa
Copy link
Contributor

The Reset bug might be linked to Ember itself (emberjs/ember.js#19180), the related PR has only been merged in v3.24.0

aatauil added a commit to lblod/ember-submission-form-fields that referenced this pull request Jan 15, 2021
No need for {{on 'click' null}. Suffices to just not define a click handler. Fixes lblod/frontend-toezicht-abb#8 (comment) reset error
@aatauil
Copy link
Member Author

aatauil commented Jan 15, 2021

Reset button error fixed in following PR lblod/ember-submission-form-fields#7

@claire-lovisa claire-lovisa reopened this Jan 15, 2021
@claire-lovisa claire-lovisa deleted the upgrade-to-3.20 branch January 15, 2021 21:22
@claire-lovisa claire-lovisa restored the upgrade-to-3.20 branch January 15, 2021 21:23
@claire-lovisa claire-lovisa reopened this Jan 15, 2021
@claire-lovisa
Copy link
Contributor

claire-lovisa commented Jan 15, 2021

(oops sorry for the mess)

So the reset bug is now fixed 🥳 thanks @aatauil !
We still have the "vorige" bug, which was already existing before the upgrade. Can we merge this @cecemel ?

@cecemel
Copy link
Member

cecemel commented Jan 19, 2021

Yep thanks everyone. Make sure to merge this in both dev and master of the frontend. release and bump. and then add this to app-toezicht both master and development

@claire-lovisa claire-lovisa merged commit 47827db into master Jan 19, 2021
@claire-lovisa claire-lovisa deleted the upgrade-to-3.20 branch January 19, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants