Feature/unanimous voting #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive and abstention voterss
abeforgit
changed the base branch from
master
to
feature/remove-role-from-voting
abeforgit
requested changes
Nov 5, 2021
| {{> mandateeList mandatees=this.negativeVoters property="besluit:heeftTegenstander" title="Tegenstanders" includeRole=false hideText=true}} | ||
| {{> mandateeList mandatees=this.abstentionVoters property="besluit:heeftOnthouders" title="Onthoudingen, blanco of ongeldig" includeRole=false hideText=true}} | ||
| {{/unless}} | ||
| <p>Met eenparigheid van stemmen,</p> |
There was a problem hiding this comment.
This also needs to specifiy if it was a positive unanimous vote or a negative one. so:
"De raad stemt voor, met eenparigheid van stemmen" (positive)
or
"De raad stemt tegen, met eenparigheid van stemmen" (negative)
There was a problem hiding this comment.
I don't really agree, this would be clear from the result ("gevolg") I think.
| {{> mandateeList mandatees=this.negativeVoters property="besluit:heeftTegenstander" title="Tegenstanders" includeRole=false}} | ||
| {{> mandateeList mandatees=this.abstentionVoters property="besluit:heeftOnthouders" title="Onthoudingen, blanco of ongeldig" includeRole=false}} | ||
| {{/unless}} | ||
| <p>Met als gevolg,</p> |
There was a problem hiding this comment.
this should be outside of the if block, it should also show when its unanimous
There was a problem hiding this comment.
I thought it was replaced by the Met eenparigheid van stemmen but I will put it outside :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77 Should be merged first