Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --memprofile option. Add memprofile to sample config. #44

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Add --memprofile option. Add memprofile to sample config. #44

merged 2 commits into from
Jun 3, 2022

Conversation

moodyjon
Copy link
Collaborator

@moodyjon moodyjon commented Jun 3, 2022

Unbundled from PR #43

See that for usage/testing.

@coveralls
Copy link

coveralls commented Jun 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2436540794

  • 0 of 16 (0.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 51.765%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lbcd.go 0 16 0.0%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 75.84%
lbcd.go 6 0%
Totals Coverage Status
Change from base Build 2403229780: -0.02%
Covered Lines: 22409
Relevant Lines: 43290
💛 - Coveralls

roylee17
roylee17 requested changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@roylee17 roylee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

docs.go needs to updated as well.

--memprofile= Write memory profile to the specified file"

@lbry-bot lbry-bot assigned roylee17 and unassigned roylee17 Jun 3, 2022
@moodyjon moodyjon requested a review from roylee17 June 3, 2022 18:58
@lbry-bot lbry-bot assigned roylee17 and unassigned roylee17 Jun 3, 2022
@lbry-bot lbry-bot assigned roylee17 and unassigned roylee17 Jun 3, 2022
@roylee17 roylee17 merged commit 15191b7 into lbryio:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roylee17 roylee17 roylee17 approved these changes

Assignees

@roylee17 roylee17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moodyjon @coveralls @roylee17