Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mining fix segwit coinbase rejection #84

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

roylee17
Copy link
Collaborator

Fix #83

Many thanks to zpool for close collaboration on this issue.

Some popular pool software, yiimp for example, constructs coinbase
in pre-BIP0141 style, which results in rejection of submitblock.
@roylee17 roylee17 self-assigned this Aug 12, 2022
@roylee17 roylee17 added the mining Mining (including pool) related issues label Aug 12, 2022
@roylee17 roylee17 merged commit be0d7de into master Aug 12, 2022
@roylee17 roylee17 deleted the roylee/mining-fix-segwit-coinbase-rejection branch August 12, 2022 17:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2848370314

  • 0 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 51.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
blockchain/merkle.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
integration/rpctest/blockgen.go 2 83.78%
Totals Coverage Status
Change from base Build 2816275515: 0.006%
Covered Lines: 22477
Relevant Lines: 43334

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mining Mining (including pool) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

submitblock reject blocks due to missing witness in coinbase.
2 participants