Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txscript: validate claimscript size #88

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

roylee17
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Aug 30, 2022

Pull Request Test Coverage Report for Build 2959954759

  • 5 of 19 (26.32%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 51.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
txscript/claimscript.go 5 19 26.32%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.31%
Totals Coverage Status
Change from base Build 2858449374: 0.02%
Covered Lines: 22485
Relevant Lines: 43507

💛 - Coveralls

@roylee17 roylee17 force-pushed the roylee/txscript-validate-claim-script-size branch from 70d0d8f to 12f0004 Compare August 30, 2022 22:22
@roylee17 roylee17 merged commit ce37025 into master Aug 30, 2022
@roylee17 roylee17 deleted the roylee/txscript-validate-claim-script-size branch August 30, 2022 22:30
@moodyjon
Copy link
Collaborator

For what it's worth, I was looking at this for ~30min and comparing with lbrycrd. I did not see anything wrong, and no complaints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants