Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: make getblock return orphans #91

Merged
merged 2 commits into from
Sep 1, 2022
Merged

rpc: make getblock return orphans #91

merged 2 commits into from
Sep 1, 2022

Conversation

roylee17
Copy link
Collaborator

@roylee17 roylee17 commented Sep 1, 2022

Fix #90

@roylee17 roylee17 added the rpc RPC related issues label Sep 1, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2968213794

  • 1 of 31 (3.23%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 51.634%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 1 0.0%
blockchain/chain.go 0 5 0.0%
btcjson/walletsvrcmds.go 1 7 14.29%
rpcclient/wallet.go 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
integration/rpctest/blockgen.go 2 83.78%
Totals Coverage Status
Change from base Build 2959992198: -0.03%
Covered Lines: 22478
Relevant Lines: 43533
💛 - Coveralls

@roylee17 roylee17 merged commit 5d7a219 into master Sep 1, 2022
@roylee17 roylee17 deleted the rpc-make-getblock-return-orphans branch September 1, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roylee17 roylee17

Labels
rpc RPC related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make getblock return orphan blocks with confirmation: -1
2 participants
@roylee17 @coveralls