Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1025 #1027

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix issue #1025 #1027

merged 1 commit into from
Oct 12, 2020

Conversation

ycohen-dev
Copy link
Contributor

Increased size of currency selection spinner in publish form fragment
Now spinner is in proper size to display "LBRY Credits" default value

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Layout issue in publishing form fragment - currency selection spinner
inside Price section (when Price is toggled on)
now big enough to display default currency "LBRY Credits"
(Increased spinner width)

Issue Number: 1025

What is the current behavior?

Currency selection spinner shows truncated string "LBRY .."
instead of the full default value "LBRY Credits"

What is the new behavior?

Currency selection spinner now displaying the full "LBRY Credits" value

Increased size of currency selection spinner in publish form fragment
Now spinner is in proper size to display "LBRY Credits" default value
@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Oct 10, 2020
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@akinwale akinwale merged commit 6644907 into lbryio:master Oct 12, 2020
@ycohen-dev ycohen-dev deleted the fix_issue_1025 branch October 14, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants