Fix for text not rendering after # in markdown #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTML generated code is correct, so in order to test it, visiting some test claims would be required. I suggest visitng following claim before and after applying the PR: |
|
@akinwale please review/merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #960 (partial fix, do not close it)
What is the current behavior?
Due to some change introduced in Chrome, WebViews are unable to render anything after the first '#'. If that happens at the beginning of the markdown document, the HTML render will not be displayed, although the HTML code itself is correct.
Strings like '#1', '#hashtag' will make the problem appear.
What is the new behavior?
This fix changes the '#' into '%23' on the HTML generated code from markdown.
Other information
The issue indicated above was about two distincts problems. This one fixes the one from the German blog post. That file was modified, so it is no longer showing the problem. However, it was identified as being related to '#'.
The other one was about lbrycast style of claims, where video was embedded into the markdown using an IFRAME. I will also try to fix that in some future PR.