Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1034 #1036

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix issue #1034 #1036

merged 1 commit into from
Oct 16, 2020

Conversation

ycohen-dev
Copy link
Contributor

Hide notifications when entering PiP mode

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 1034

What is the current behavior?

Notifications container remain visible when entering PiP mode , blocking video

What is the new behavior?

Video visible
Notifications get hidden when entering PiP mode

Hide notifications when entering PiP mode
@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Oct 15, 2020
@akinwale
Copy link
Contributor

Thanks for this.

@akinwale akinwale merged commit 0ec09d7 into lbryio:master Oct 16, 2020
@ycohen-dev ycohen-dev deleted the fix_issue_1034 branch October 16, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants